feat: Diagnose trait errors 🎉#22186
Open
ChayimFriedman2 wants to merge 3 commits intorust-lang:masterfrom
Open
feat: Diagnose trait errors 🎉#22186ChayimFriedman2 wants to merge 3 commits intorust-lang:masterfrom
ChayimFriedman2 wants to merge 3 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
2faaf56 to
0785743
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
0785743 to
5939ef1
Compare
In rustc it is not, but we're unlikely to add something non-`Copy` to it in the near future, and it simplifies the code. This was basically adding a derive then `cargo clippy --fix` and `cargo fmt`.
I.e. type does not implement trait. There are a lot of other solver errors to be emitted, and the error is pretty simple currently, but this is a huge step!
ChayimFriedman2
force-pushed
the
trait-errors
branch
from
5939ef1 to
73dce3f
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Collaborator
|
☔ The latest upstream changes (possibly #22197) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I.e. type does not implement trait.
There are a lot of other solver errors to be emitted, and the error is pretty simple currently, but this is a huge step!
Watch this wonderful video:
trait.errors.mp4